Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

googlecloudspannerreceiver: Update dependencies #36112

Closed
dashpole opened this issue Oct 31, 2024 · 7 comments · Fixed by #37524
Closed

googlecloudspannerreceiver: Update dependencies #36112

dashpole opened this issue Oct 31, 2024 · 7 comments · Fixed by #37524
Labels
receiver/googlecloudspanner

Comments

@dashpole
Copy link
Contributor

Component(s)

receiver/googlecloudspanner

Describe the issue you're reporting

#30370 and #29830 were auto-closed since the previous codeowner didn't act on them. We should keep our dependencies up-to-date to ensure we stay on maintained versions of dependencies.

This issue is complete when:

  • github.com/mitchellh/hashstructure is updated to v2
  • github.com/renekroon/ttlcache/v2 is updated to v3
@dashpole dashpole added the needs triage New item requiring triage label Oct 31, 2024
@dashpole dashpole mentioned this issue Oct 31, 2024
Merged
@github-actions GitHub Actions
Copy link
Contributor

Pinging code owners for receiver/googlecloudspanner: @dashpole @dsimil @KiranmayiB @harishbohara11. See Adding Labels via Comments if you do not have permissions to add labels yourself.

@atoulme atoulme removed the needs triage New item requiring triage label Nov 2, 2024
@github-actions github-actions bot mentioned this issue Nov 5, 2024
Closed
@codeboten
Copy link
Contributor

#36209

@codeboten
Copy link
Contributor

#36202

@codeboten
Copy link
Contributor

One more update that needs addressing #36317

@codeboten
Copy link
Contributor

@dashpole there has been little traction on getting any of these issues looked at. I'm leaning towards removing this component once more

@manu2
Copy link
Contributor

manu2 commented Dec 4, 2024

Looking into it.

@manu2 manu2 mentioned this issue Dec 4, 2024
Closed
@dashpole
Copy link
Contributor Author

Spanner dep was updated in #36685

@dashpole dashpole mentioned this issue Jan 27, 2025
Merged
songy23 pushed a commit that referenced this issue Jan 27, 2025
@dashpole
fix(deps): update module github.com/mitchellh/hashstructure to v2 (#3…
f0086e6 
…7514)

#### Description

Supersedes
#36202

#### Link to tracking issue
Part of
#36112
chengchuanpeng pushed a commit to chengchuanpeng/opentelemetry-collector-contrib that referenced this issue Jan 28, 2025
@dashpole @chengchuanpeng
fix(deps): update module github.com/mitchellh/hashstructure to v2 (op…
6602454 
…en-telemetry#37514)

#### Description

Supersedes
open-telemetry#36202

#### Link to tracking issue
Part of
open-telemetry#36112
@dashpole dashpole mentioned this issue Jan 28, 2025
Merged
chengchuanpeng pushed a commit to chengchuanpeng/opentelemetry-collector-contrib that referenced this issue Feb 8, 2025
@dashpole @renovate @chengchuanpeng
Update module github.com/ReneKroon/ttlcache/v2 to v3 (open-telemetry#…
adff051 
…37524)

#### Description

Supersedes open-telemetry#36209

Most of the changes are obvious renames or refactors. The non-obvious
changes are:

* `Start()` must now be called on the cache to enable cleanup in the
background.
* `Stop()` can only be called once (or it will block indefinitely). I've
added a sync.Once to ensure it is only ever called once.
* `Set()` and `Get()` no longer return errors--even if Stop has already
been called. This makes some of our tests obsolete, and I removed those
tests.

#### Link to tracking issue

Fixes
open-telemetry#36112

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
receiver/googlecloudspanner
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update module github.com/ReneKroon/ttlcache/v2 to v3 dashpole/opentelemetry-collector-contrib
4 participants
@atoulme @codeboten @dashpole @manu2