Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[broken test][sumologicextension] several tests failed on Windows #36481

Closed
songy23 opened this issue Nov 21, 2024 · 3 comments · Fixed by #36772
Closed

[broken test][sumologicextension] several tests failed on Windows #36481

songy23 opened this issue Nov 21, 2024 · 3 comments · Fixed by #36772
Labels
extension/sumologic flaky test a test is flaky needs triage New item requiring triage os:windows

Comments

@songy23
Copy link
Member

songy23 commented Nov 21, 2024

Component(s)

extension/sumologic

Describe the issue you're reporting

E.g. https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/11937483258/job/33273579980

=== Failed
=== FAIL: .  (0.00s)
panic: test timed out after 10m0s
running tests:
	TestCollectorCheckingCredentialsFoundInLocalStorage (10m0s)
	TestCollectorCheckingCredentialsFoundInLocalStorage/collector_checks_found_credentials_via_heartbeat_call_-_no_registration_is_done (10m0s)
	TestCollectorReregistersAfterHTTPUnathorizedFromHeartbeat (10m0s)
	TestCollectorSendsBasicAuthHeadersOnRegistration (10m0s)
	TestRegisterEmptyCollectorName (10m0s)
...

=== FAIL: . TestRegistrationRequestPayload (unknown)

=== FAIL: . TestCollectorCheckingCredentialsFoundInLocalStorage/collector_checks_found_credentials_via_heartbeat_call_-_no_registration_is_done (unknown)
    extension_test.go:749: Storing collector credentials in temp dir: C:\Users\RUNNER~1\AppData\Local\Temp\otelcol-sumo-store-credentials-test-3707712072

=== FAIL: . TestLocalFSCredentialsStore_WorkCorrectlyForMultipleExtensions (unknown)

=== FAIL: . TestCollectorSendsBasicAuthHeadersOnRegistration (unknown)

=== FAIL: . TestRegisterEmptyCollectorNameWithBackoff (unknown)

=== FAIL: . TestRegisterEmptyCollectorNameUnrecoverableError (unknown)

=== FAIL: . TestUpdateMetadataRequestPayload (unknown)
@songy23 songy23 added flaky test a test is flaky os:windows needs triage New item requiring triage labels Nov 21, 2024
@github-actions GitHub Actions
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot mentioned this issue Nov 26, 2024
Closed
@github-actions github-actions bot mentioned this issue Dec 3, 2024
Closed
This was referenced Dec 9, 2024
Closed
Merged
@songy23

This comment was marked as off-topic.

Sign in to view
@songy23 songy23 closed this as completed Dec 9, 2024
@songy23 songy23 reopened this Dec 9, 2024
@songy23
Copy link
Member Author

songy23 commented Dec 9, 2024

nvm, turns out #36726 fixes a different issue

@github-actions github-actions bot mentioned this issue Dec 10, 2024
Closed
@pjanotti pjanotti mentioned this issue Dec 10, 2024
Merged
sbylica-splunk pushed a commit to sbylica-splunk/opentelemetry-collector-contrib that referenced this issue Dec 17, 2024
@pjanotti @sbylica-splunk
[extension/sumologic] Skip zombie processes on Windows (open-telemetr…
b8575f0 
…y#36772)

#### Description
On Windows it consistently fails to get the name of certain processes,
likely zombie process, reporting: "A device attached to the system is
not functioning."

My long term recommendation will be for the owners to directly use the
Win32 API to get process information instead of the library: while it
uses the correct permissions to get the process name it is not using the
flag that allows to get the device name path which should avoid this
issue even for zombie processes, I'm not sure if that is desirable or
not.


#### Link to tracking issue
Fixes open-telemetry#36481

#### Testing
Repro the failure locally and checked that the test passed locally with
the change.
I couldn't lint it locally on Windows (tool crash, will use CI to check
that)

#### Documentation

Added changelog
mterhar pushed a commit to mterhar/opentelemetry-collector-contrib that referenced this issue Dec 19, 2024
@pjanotti @mterhar
[extension/sumologic] Skip zombie processes on Windows (open-telemetr…
32b43a2 
…y#36772)

#### Description
On Windows it consistently fails to get the name of certain processes,
likely zombie process, reporting: "A device attached to the system is
not functioning."

My long term recommendation will be for the owners to directly use the
Win32 API to get process information instead of the library: while it
uses the correct permissions to get the process name it is not using the
flag that allows to get the device name path which should avoid this
issue even for zombie processes, I'm not sure if that is desirable or
not.


#### Link to tracking issue
Fixes open-telemetry#36481

#### Testing
Repro the failure locally and checked that the test passed locally with
the change.
I couldn't lint it locally on Windows (tool crash, will use CI to check
that)

#### Documentation

Added changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
extension/sumologic flaky test a test is flaky needs triage New item requiring triage os:windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[extension/sumologic] Skip zombie processes on Windows pjanotti/opentelemetry-service-contrib
2 participants
@pjanotti @songy23