Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[processor/tailsampling] Ability to understand which tailsampling policies attributed to a sampling decision of a trace #36811

Closed
mugli opened this issue Dec 12, 2024 · 2 comments
Labels
enhancement New feature or request needs triage New item requiring triage processor/tailsampling Tail sampling processor

Comments

@mugli
Copy link

mugli commented Dec 12, 2024

Component(s)

processor/tailsampling

Is your feature request related to a problem? Please describe.

We frequently need to understand which tailsampling policies contributed to the decision of sampling a trace. The reasons:

  • Understanding contributing factors
  • Understanding if we need to optimize certain policies

Additionally, if we could know which traces are sampled from random/probabilistic sampling, we could use those particular subset of traces to do further analytics (calculate distribution of error, latency). It's not possible now because without identifying traces from random/probabilistic sampling the distribution is skewed (towards error, latency etc)

Describe the solution you'd like

Can we make it (optionally) configurable to attach an attribute in the root-span of a trace with the names of root-level policies that evaluated true during tailsampling, also another attribute of list of policies that evaluated to false?

Describe alternatives you've considered

No response

Additional context

No response

@mugli mugli added enhancement New feature or request needs triage New item requiring triage labels Dec 12, 2024
@github-actions github-actions bot added the processor/tailsampling Tail sampling processor label Dec 12, 2024
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@mugli
Copy link
Author

mugli commented Dec 12, 2024

Sorry, I just realized it might be duplicate of this: #35180

Closing this one. I'll follow the other one as that came first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs triage New item requiring triage processor/tailsampling Tail sampling processor
Projects
None yet
Development

No branches or pull requests

1 participant