-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add attributes to node and pod entities #36859
Labels
Comments
jinja2
added
enhancement
New feature or request
needs triage
New item requiring triage
labels
Dec 16, 2024
Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
jinja2
changed the title
add attributes to node and pod metadata
add attributes to node and pod entities
Dec 18, 2024
This was referenced Dec 24, 2024
dmitryax
pushed a commit
that referenced
this issue
Jan 6, 2025
#### Description Adds below additional metadata attributes to the node and pod entity - k8s.pod.phase - This is similar to the existing metric k8s.pod.phase. The values can be Pending, Running, Succeeded, Failed, Unknown. k8s.pod.status_reason - Similar to k8s.pod.status_reason metric. A brief CamelCase message indicating details about why the pod is in this state. Example values - Evicted, NodeLost, UnexpectedAdmissionError k8s.node.condition_{type} - similar to existing metrics enabled by the config node_conditions_to_report, e.g. k8s.node.condition_ready. Add [k8s default kubelet conditions](https://pkg.go.dev/k8s.io/api/core/v1#NodeConditionType) only. We'll be tracking changes to entitiy attributes for k8s in [this](open-telemetry/semantic-conventions#1693) SemConv issue. #### Link to tracking issue Fixes - #36859 #### Testing Added unit tests and verified in cluster
@jinja2 as part of this work lets make sure all the semantic conventions are aligned |
AkhigbeEromo
pushed a commit
to sematext/opentelemetry-collector-contrib
that referenced
this issue
Jan 13, 2025
…elemetry#36862) #### Description Adds below additional metadata attributes to the node and pod entity - k8s.pod.phase - This is similar to the existing metric k8s.pod.phase. The values can be Pending, Running, Succeeded, Failed, Unknown. k8s.pod.status_reason - Similar to k8s.pod.status_reason metric. A brief CamelCase message indicating details about why the pod is in this state. Example values - Evicted, NodeLost, UnexpectedAdmissionError k8s.node.condition_{type} - similar to existing metrics enabled by the config node_conditions_to_report, e.g. k8s.node.condition_ready. Add [k8s default kubelet conditions](https://pkg.go.dev/k8s.io/api/core/v1#NodeConditionType) only. We'll be tracking changes to entitiy attributes for k8s in [this](open-telemetry/semantic-conventions#1693) SemConv issue. #### Link to tracking issue Fixes - open-telemetry#36859 #### Testing Added unit tests and verified in cluster
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Component(s)
receiver/k8scluster
Is your feature request related to a problem? Please describe.
Metrics for certain pod/node status fields do not work well for filtering in backends. We'd like to introduce some of this information as metadata on pod and node entities.
Describe the solution you'd like
I'd like to add below additional attributes to the node and pod entity/metadata.
k8s.pod.phase
- This is similar to the existing metrick8s.pod.phase
. The values can bePending
,Running
,Succeeded
,Failed
,Unknown
.k8s.pod.status_reason
- Similar tok8s.pod.status_reason
metric. A brief CamelCase message indicating details about why the pod is in this state. Example values -Evicted
,NodeLost
,UnexpectedAdmissionError
k8s.node.condition_{type}
- similar to existing metrics enabled by the confignode_conditions_to_report
, e.g.k8s.node.condition_ready
. Since additional custom node conditions can exist, I think sticking with the k8s native kubelet conditions would be better. Or we can use thenode_conditions_to_report
config here.Describe alternatives you've considered
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: