From 55c827b2b6d8badbd99e81c1460d1ca85204e187 Mon Sep 17 00:00:00 2001 From: Sam DeHaan Date: Sun, 24 Nov 2024 00:49:24 -0500 Subject: [PATCH 1/2] Use default http transport that looks at proxy environment variables --- receiver/mongodbatlasreceiver/internal/mongodb_atlas_client.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/receiver/mongodbatlasreceiver/internal/mongodb_atlas_client.go b/receiver/mongodbatlasreceiver/internal/mongodb_atlas_client.go index b3ccb9a3b737..5f8157a6f26f 100644 --- a/receiver/mongodbatlasreceiver/internal/mongodb_atlas_client.go +++ b/receiver/mongodbatlasreceiver/internal/mongodb_atlas_client.go @@ -135,7 +135,7 @@ func NewMongoDBAtlasClient( backoffConfig configretry.BackOffConfig, log *zap.Logger, ) *MongoDBAtlasClient { - defaultTransporter := &http.Transport{} + defaultTransporter := http.DefaultTransport.(*http.Transport) t := digest.NewTransportWithHTTPTransport(publicKey, privateKey, defaultTransporter) roundTripper := newClientRoundTripper(t, log, backoffConfig) tc := &http.Client{Transport: roundTripper} From 5a23f2f5e184718591ebe553f9b60c28f8965348 Mon Sep 17 00:00:00 2001 From: Sam DeHaan Date: Mon, 25 Nov 2024 10:38:09 -0500 Subject: [PATCH 2/2] Add changelog entry --- .chloggen/mongodbatlas-default-transport.yaml | 27 +++++++++++++++++++ 1 file changed, 27 insertions(+) create mode 100644 .chloggen/mongodbatlas-default-transport.yaml diff --git a/.chloggen/mongodbatlas-default-transport.yaml b/.chloggen/mongodbatlas-default-transport.yaml new file mode 100644 index 000000000000..087a06b6258d --- /dev/null +++ b/.chloggen/mongodbatlas-default-transport.yaml @@ -0,0 +1,27 @@ +# Use this changelog template to create an entry for release notes. + +# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix' +change_type: bug_fix + +# The name of the component, or a single word describing the area of concern, (e.g. filelogreceiver) +component: mongodbatlasreceiver + +# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`). +note: Update the mongoDB Atlas receiver to use the Default HTTP Transport that supports default proxy configuration + +# Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists. +issues: [36412] + +# (Optional) One or more lines of additional information to render under the primary note. +# These lines will be padded with 2 spaces and then inserted directly into the document. +# Use pipe (|) for multiline entries. +subtext: + +# If your change doesn't affect end users or the exported elements of any package, +# you should instead start your pull request title with [chore] or use the "Skip Changelog" label. +# Optional: The change log or logs in which this entry should be included. +# e.g. '[user]' or '[user, api]' +# Include 'user' if the change is relevant to end users. +# Include 'api' if there is a change to a library API. +# Default: '[user]' +change_logs: [user]