Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade pprofiletest to proto v1.5.0 #36868

Merged
merged 5 commits into from
Dec 21, 2024
Merged

Upgrade pprofiletest to proto v1.5.0 #36868

merged 5 commits into from
Dec 21, 2024
+16,780 −16,887

Conversation

dmathieu
Copy link
Member

Description

This follows open-telemetry/opentelemetry-collector#11932, and upgrades pprofiletest with the breaking changes from the latest profile proto.

@dmathieu dmathieu changed the title Upgrade pprofiletest to proto v1.5.0G Upgrade pprofiletest to proto v1.5.0 Dec 17, 2024
@dmathieu dmathieu mentioned this pull request Dec 17, 2024
Merged
@dmathieu
Copy link
Member Author

This PR allows fixing the core tests from open-telemetry/opentelemetry-collector#11932, and probably requires being merged in a coordinated way.

@dmathieu dmathieu marked this pull request as ready for review December 17, 2024 10:28
@dmathieu dmathieu requested a review from a team as a code owner December 17, 2024 10:28
@songy23 songy23 added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Dec 20, 2024
@songy23
Copy link
Member

songy23 commented Dec 20, 2024

I guess you will need to run make update-otel in your branch and commit the changes in this PR.

@songy23 songy23 added the release:blocker The issue must be resolved before cutting the next release label Dec 20, 2024
codeboten
codeboten approved these changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ran make update-otel to unblock merging this PR

@codeboten codeboten merged commit f2d6f3c into open-telemetry:main Dec 21, 2024
161 checks passed
@github-actions github-actions bot added this to the next release milestone Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeboten codeboten codeboten approved these changes

@atoulme atoulme atoulme approved these changes

@djaglowski djaglowski Awaiting requested review from djaglowski djaglowski is a code owner

@fatsheep9146 fatsheep9146 Awaiting requested review from fatsheep9146 fatsheep9146 is a code owner

@MovieStoreGuy MovieStoreGuy Awaiting requested review from MovieStoreGuy MovieStoreGuy is a code owner

@andrzej-stencel andrzej-stencel Awaiting requested review from andrzej-stencel andrzej-stencel is a code owner

@crobert-1 crobert-1 Awaiting requested review from crobert-1 crobert-1 is a code owner

@dashpole dashpole Awaiting requested review from dashpole dashpole is a code owner

@jmacd jmacd Awaiting requested review from jmacd jmacd is a code owner

@dmitryax dmitryax Awaiting requested review from dmitryax dmitryax is a code owner

@jpkrohling jpkrohling Awaiting requested review from jpkrohling jpkrohling is a code owner

@evan-bradley evan-bradley Awaiting requested review from evan-bradley evan-bradley is a code owner

@TylerHelmuth TylerHelmuth Awaiting requested review from TylerHelmuth TylerHelmuth is a code owner

@ChrsMark ChrsMark Awaiting requested review from ChrsMark ChrsMark is a code owner

@yurishkuro yurishkuro Awaiting requested review from yurishkuro yurishkuro is a code owner

@mwear mwear Awaiting requested review from mwear mwear is a code owner

@mx-psi mx-psi Awaiting requested review from mx-psi mx-psi is a code owner

@bogdandrutu bogdandrutu Awaiting requested review from bogdandrutu bogdandrutu is a code owner

@songy23 songy23 Awaiting requested review from songy23 songy23 is a code owner

@tigrannajaryan tigrannajaryan Awaiting requested review from tigrannajaryan tigrannajaryan is a code owner

@jsuereth jsuereth Awaiting requested review from jsuereth jsuereth is a code owner

Assignees

@codeboten codeboten

Labels
cmd/githubgen cmd/opampsupervisor cmd/otelcontribcol otelcontribcol command cmd/oteltestbedcol cmd/telemetrygen telemetrygen command confmap/provider/aesprovider confmap/provider/s3provider confmap/provider/secretsmanagerprovider connector/count connector/datadog connector/exceptions connector/failover connector/grafanacloud connector/otlpjson connector/roundrobin connector/routing connector/servicegraph connector/signaltometrics connector/spanmetrics connector/sum exporter/alertmanager exporter/alibabacloudlogservice Alibaba components exporter/awscloudwatchlogs awscloudwatchlogs exporter exporter/awsemf awsemf exporter exporter/awskinesis exporter/awss3 exporter/awsxray exporter/azuredataexplorer exporter/azuremonitor exporter/carbon exporter/cassandra exporter/clickhouse exporter/coralogix exporter/datadog Datadog components exporter/dataset exporter/doris exporter/elasticsearch exporter/file exporter/googlecloud exporter/googlecloudpubsub exporter/googlemanagedprometheus Google Managed Prometheus exporter exporter/honeycombmarker exporter/influxdb exporter/kafka exporter/kinetica exporter/loadbalancing exporter/logicmonitor exporter/logzio pkg/pdatatest release:blocker The issue must be resolved before cutting the next release Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
next release
Development

Successfully merging this pull request may close these issues.
4 participants
@dmathieu @songy23 @atoulme @codeboten