Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[config] Investigate how goroutines and Shutdown should be handled in config modules #9831

Open
TylerHelmuth opened this issue Mar 25, 2024 · 0 comments

Comments

@TylerHelmuth
Copy link
Member

TylerHelmuth commented Mar 25, 2024

Looking at this some more I really don't like that any component that uses configtls has to add this check. I am worried about components not realizing that the configtls.TLSSetting embedded in confighttp.ServerConfig needs a Shutdown call.

I think it is out of scope of this PR, which is only trying to solve a leak added by existing functionality, but I think we should take another look at how config modules should handle goroutines and Shutdown.

Originally posted by @TylerHelmuth in #9220 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant