[TEST] Change is_called_ and got_response_ to use atomic
#3204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for opentelemetry-cpp-api-docs canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3204 +/- ##
=======================================
Coverage 87.83% 87.83%
=======================================
Files 195 195
Lines 6154 6154
=======================================
Hits 5405 5405
Misses 749 749 |
marcalff
changed the title
is_called_ and got_response_ to use atomicis_called_ and got_response_ to use atomic
malkia
added a commit
to malkia/opentelemetry-cpp
that referenced
this pull request
Dec 13, 2024
[TEST] Change `is_called_` and `got_response_` to use atomic (open-telemetry#3204)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3172
Changes
is_called_andgot_response_to use atomicNot sure if it can solve the problems, we can reopen it if it still exists.
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes