-
Notifications
You must be signed in to change notification settings - Fork 780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SemanticConventions attribute name constants differ from spec #4101
Comments
New tag is was released as 1.17.0: https://github.com/open-telemetry/opentelemetry-specification/blob/3d594588815fa4564fe35984e8b1a714e54d48f2/CHANGELOG.md?plain=1#L91 Current semantic convention was generated from 1.13.0 https://github.com/open-telemetry/opentelemetry-dotnet/blob/main/src/OpenTelemetry.SemanticConventions/scripts/semantic-conventions/generate.ps1#L6 Is there any chance that you create PR with regenerated code? |
I'll certainly have a go at it. Probably later today. |
I opened a PR but simply updating the versions didn't work. I found this issue and had to add a volume mount to the
|
This issue was marked stale due to lack of activity and will be closed in 7 days. Commenting will instruct the bot to automatically remove the label. This bot runs once per day. |
Closed as inactive. Feel free to reopen if this issue is still a concern. |
Bug Report
OpenTelemetry.SemanticConventions 1.0.0-rc9.9
Symptom
I notice that some of the constants in the package don't match the values in the spec; for example
public const string AttributeMessagingMessageId = "messaging.message_id";
but the spec refers tomessaging.message.id
.The PR that introduced this says the values were autogenerated so maybe it's just out of date? I had a quick look at the build-tools and it links to the java package which has a constant that does match the spec.
The text was updated successfully, but these errors were encountered: