Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing test - Oban no longer sets priority by default #287

Closed
bryannaegele opened this issue Feb 14, 2024 · 1 comment · Fixed by #294
Closed

Failing test - Oban no longer sets priority by default #287

bryannaegele opened this issue Feb 14, 2024 · 1 comment · Fixed by #294
Labels
bug Something isn't working opentelemetry_oban

Comments

@bryannaegele
Copy link
Collaborator

Not a big deal but it appears Oban stopped setting priority by default on all jobs and is set to nil?

1) test records span on job insertion (OpentelemetryObanTest)
Error:      test/opentelemetry_oban_test.exs:34
     match (=) failed
     code:  assert %{
              "messaging.destination": "events",
              "messaging.destination_kind": :queue,
              "messaging.oban.job_id": _job_id,
              "messaging.oban.max_attempts": 1,
              "messaging.oban.priority": 0,
              "messaging.oban.worker": "TestJob",
              "messaging.system": :oban
            } = :otel_attributes.map(attributes)
     left:  %{
              "messaging.destination": "events",
              "messaging.destination_kind": :queue,
              "messaging.oban.job_id": _job_id,
              "messaging.oban.max_attempts": 1,
              "messaging.oban.priority": 0,
              "messaging.oban.worker": "TestJob",
              "messaging.system": :oban
            }
     right: %{
              "messaging.destination": "events",
              "messaging.destination_kind": :queue,
              "messaging.oban.job_id": 7,
              "messaging.oban.max_attempts": 1,
              "messaging.oban.priority": nil,
              "messaging.oban.worker": "TestJob",
              "messaging.system": :oban
            }
     stacktrace:
       test/opentelemetry_oban_test.exs:47: (test)
@yordis
Copy link
Contributor

yordis commented Feb 22, 2024

This could be closed, has been fixed by #247

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working opentelemetry_oban
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants