Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow psycopg2-binary as an alternative to psycopg2 #2598

Closed
DavidS-cloud opened this issue Apr 12, 2022 · 2 comments
Closed

Allow psycopg2-binary as an alternative to psycopg2 #2598

DavidS-cloud opened this issue Apr 12, 2022 · 2 comments

Comments

@DavidS-cloud
Copy link

Is your feature request related to a problem?

We're using psycopg2-binary to avoid the complications of compiling psycopg2 on deployment. When using the Psycopg2Instrumentor, it fails with "DependencyConflict: requested: "psycopg2 >= 2.7.3.1" but found: "None"". Replacing our psycopg2-binary requirement with regular psycopg2 works just fine, but is very inconvenient for our deployment.

Describe the solution you'd like
Psycopg2Instrumentor can detect and work with both packages.

Describe alternatives you've considered
If it is not possible to have alternate dependencies, another option would be to have a Psycopg2BinaryInstrumentor that just proxies everything to the regular Psycopg2Instrumentor.

@owais
Copy link
Contributor

owais commented Apr 12, 2022

@owais owais closed this as completed Apr 12, 2022
@owais
Copy link
Contributor

owais commented Apr 12, 2022

Let's discuss this over at open-telemetry/opentelemetry-python-contrib#541

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants