Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add steps on how to turn off tracing in graphQL #1010

Open
alexus37 opened this issue Jun 14, 2024 · 4 comments
Open

Add steps on how to turn off tracing in graphQL #1010

alexus37 opened this issue Jun 14, 2024 · 4 comments
Labels
documentation Improvements or additions to documentation keep Ensures stale-bot keeps this issue/PR open

Comments

@alexus37
Copy link

alexus37 commented Jun 14, 2024

I'm excited to learn about the steps needed to disable otel tracing in GraphQL.

cc @arielvalentin

@arielvalentin
Copy link
Collaborator

To elaborate here a bit we are missing docs on disabling or customizing instrumentation using environment variables. Right now, we only have it via configs.

https://opentelemetry.io/docs/languages/ruby/libraries/#overriding-configuration-for-specific-instrumentation-libraries

@arielvalentin
Copy link
Collaborator

The RubyDocs has a snippet that we should include on opentelemetry.io: https://rubydoc.info/gems/opentelemetry-instrumentation-base/0.22.3/OpenTelemetry/Instrumentation/Base

The instrumention class establishes a convention for disabling an instrumentation by environment variable and local configuration. An instrumentation disabled by environment variable will take precedence over local config. The convention for environment variable name is the library name, upcased with '::' replaced by underscores, OPENTELEMETRY shortened to OTEL_LANG, and '_ENABLED' appended. For example: OTEL_RUBY_INSTRUMENTATION_SINATRA_ENABLED = false.

@robbkidd As you have motioned may times before... we need better tooling around documentation and options!

Copy link
Contributor

👋 This issue has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the keep label to hold stale off permanently, or do nothing. If you do nothing this issue will be closed eventually by the stale bot.

@github-actions github-actions bot added the stale Marks an issue/PR stale label Jul 15, 2024
@kaylareopelle kaylareopelle added keep Ensures stale-bot keeps this issue/PR open documentation Improvements or additions to documentation and removed stale Marks an issue/PR stale labels Jul 16, 2024
@xuan-cao-swi
Copy link
Contributor

Would the updated doc resolve this kind issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation keep Ensures stale-bot keeps this issue/PR open
Projects
None yet
Development

No branches or pull requests

4 participants