Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update semantic conventions to 1.22 #1108

Closed
mladedav opened this issue Jun 10, 2023 · 1 comment · Fixed by #1153
Closed

Update semantic conventions to 1.22 #1108

mladedav opened this issue Jun 10, 2023 · 1 comment · Fixed by #1153
Labels
A-common Area:common issues that not related to specific pillar

Comments

@mladedav
Copy link

mladedav commented Jun 10, 2023

This project's semantic conventions crate defines http.status_code while semantic conventions seem to define http.response.status_code.

The crate currently uses semantic conventions 1.20 or older. List of changes between 1.20 and later is in this issue.

@mladedav mladedav changed the title Semantic conventions http status code does not match spec Update semantic conventions to 1.22 Jun 10, 2023
@TommyCpp TommyCpp added the A-common Area:common issues that not related to specific pillar label Jun 26, 2023
@michaeljohnalbers
Copy link

michaeljohnalbers commented Jul 6, 2023

I took a look at this and found a few things

  1. The semantic conventions used to generate the constants have been moved into their own repo. This happened as part of the 1.21 release of the specification repo.
  2. The new semantic conventions repo does not have any tags/releases/etc. (as of this writing) to which the generation script can refer. And currently, according to the README, it only matches the 1.21 spec.
  3. There is a new version of the Docker otel/semconvgen Docker image the script uses. That should be updated as well.

Until the issues in item 2 are rectified, I think this issue should not be worked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-common Area:common issues that not related to specific pillar
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants