From 93dc407ed35417d58e2da9f70f0e8c35e56ede62 Mon Sep 17 00:00:00 2001 From: Liudmila Molkova Date: Tue, 11 Apr 2023 10:17:41 -0700 Subject: [PATCH] query is sampling relevant --- semantic_conventions/trace/http.yaml | 7 ++++--- specification/trace/semantic_conventions/http.md | 1 + 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/semantic_conventions/trace/http.yaml b/semantic_conventions/trace/http.yaml index 6aab2f5a9c0..da1effb7be4 100644 --- a/semantic_conventions/trace/http.yaml +++ b/semantic_conventions/trace/http.yaml @@ -136,13 +136,14 @@ groups: - ref: net.sock.host.addr requirement_level: opt_in - ref: net.sock.host.port - - ref: url.path - sampling_relevant: true - requirement_level: required - ref: url.scheme sampling_relevant: true requirement_level: required examples: ["http", "https"] + - ref: url.path + sampling_relevant: true + requirement_level: required - ref: url.query + sampling_relevant: true requirement_level: conditionally_required: if available. diff --git a/specification/trace/semantic_conventions/http.md b/specification/trace/semantic_conventions/http.md index 35ac4e0c2c4..03da97680d7 100644 --- a/specification/trace/semantic_conventions/http.md +++ b/specification/trace/semantic_conventions/http.md @@ -290,6 +290,7 @@ Following attributes MUST be provided **at span creation time** (when provided a * [`net.host.name`](span-general.md) * [`net.host.port`](span-general.md) * `url.path` +* `url.query` * `url.scheme`