Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a memorylimiter extension #173

Open
moh-osman3 opened this issue Apr 4, 2024 · 0 comments
Open

Add a memorylimiter extension #173

moh-osman3 opened this issue Apr 4, 2024 · 0 comments
Assignees

Comments

@moh-osman3
Copy link
Contributor

Implement a memorylimiter extension that can replace the behavior of the concurrentbatchprocessor's inflight memory limiter. Instead of waiting until the concurrentbatchprocessor to apply an in flight byte limits, we should try to limit requests before they reach the otlp receiver's grpc server. This will be a step in the right direction for resolving memory issues observed in the receiver where too many waiters can build up a lot of memory even if the in flight memory is limited in the concurrentbatchprocessor.

@moh-osman3 moh-osman3 self-assigned this Apr 4, 2024
jmacd pushed a commit that referenced this issue Apr 23, 2024
This PR adds a new semaphore object to limit both on bytes and number of
waiters. This should help with some memory issues in the collector where
the receiver holds on to too much memory, either due to large/frequent
requests or too many waiters blocked. Related to
#173
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant