Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider atomic counters in internal/otelarrow/admission #270

Open
jmacd opened this issue Nov 6, 2024 · 0 comments
Open

Consider atomic counters in internal/otelarrow/admission #270

jmacd opened this issue Nov 6, 2024 · 0 comments

Comments

@jmacd
Copy link
Contributor

jmacd commented Nov 6, 2024

As @lquerel suggested here, open-telemetry/opentelemetry-collector-contrib#36140 (comment), we may wish to reduce the potential for lock contention.

The initial contents of the PR contain an admission2 package which is derived from a well-tested internal code base (with permission). Because the code is well tested w/ Mutex locking, I want to pursue merging it and replacing the original admission (which is FIFO and has a race condition) and the new admission2 (which is LIFO and addresses the race condition).

After the race condition and FIFO->LIFO change is applied, it will be easier to study and test the contention topic exposed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant