Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New arrow data types #85

Open
djaglowski opened this issue May 8, 2023 · 2 comments
Open

New arrow data types #85

djaglowski opened this issue May 8, 2023 · 2 comments

Comments

@djaglowski
Copy link
Member

djaglowski commented May 8, 2023

Is your feature request related to a problem? Please describe.
The discussion on open-telemetry/oteps#171 included some comments (example) about potentially needing to define a new signal type in the collector, in order to support columnar encodings. I'd like to offer a more specific proposal for how this should be handled in the collector.

Describe the solution you'd like
For each current data type supported in the collector, introduce a corresponding arrow data type. Names here are only meant as placeholders, but let's say atrace, ametric, and alog.

Introducing three distinct data types means that we could use the collector's pipeline system to our advantage.

  • Each type of component opts into each data type independently. Therefore, support for each arrow type can be added as necessary.
  • Pipelines are always associated with exactly one data type, so this would allow for the construction of arrow-specific pipelines. Validation of a pipeline enforces that all components within the pipeline support that data type.
  • Connectors support ordered pairs of data types. Adding new arrow data types would allow for a connector that supports translation between pdata and arrow formats. (Phase 2 adaptation layer). Consequently, this allows data of either type to move through processors and exporters that only support one of the pdata or arrow formats.
    • e.g. arrow receiver -> arrow processor -> to_pdata connector -> pdata processor -> to_arrow connector -> arrow exporter
@jmacd
Copy link
Contributor

jmacd commented Jun 20, 2023

Thanks - I like this proposal.

@lquerel
Copy link
Contributor

lquerel commented Jun 20, 2023

I really like this approach, as it brings us closer to optimizing the collector for transport and processing, enabling an optimized end-to-end Arrow representation without breaking the existing ecosystem.

@jmacd jmacd transferred this issue from open-telemetry/otel-arrow-collector Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants