Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Miscalculation of lbas read/written #1

Open
lixiaokeng opened this issue Jan 11, 2021 · 1 comment
Open

Miscalculation of lbas read/written #1

lixiaokeng opened this issue Jan 11, 2021 · 1 comment

Comments

@lixiaokeng
Copy link
Contributor

lixiaokeng commented Jan 11, 2021 •
edited
Loading

libatasmart/atasmart.c
Line 1225 in de62589
a->pretty_value = fourtyeight * 65536LLU * 512LLU / 1000000LLU;
This line seems does lbas-read/written * 65536 * 512 (sectors) / 1000000 (mb). However on my various varieties of Samsung ssd this 65536 multiple is incorrect, it should actually just be * 512 / 1000000 to get mb. This means I'm having to put a *16 factor in to convert to bytes/sec

upstream issue link: Rupan/libatasmart#5 (comment)
@lixiaokeng
Copy link
Contributor Author

Now I have no SSamsung ssd. This isuue need some time to verify.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lixiaokeng