-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inconsistencies with _extends values #52
Comments
The concept is that paths starting with "/" are absolute paths, used to refer to schemas in other repositories (i.e. other sub-modules), while paths without "/" are relative to the current repository/submodule. We could make all paths absolute, but I don't see the current usage as inconsistent. |
It is indeed not inconsistent, but we should discuss this anyway. @Raphael-Gazzotti could you check the relevant section in the pipeline so we know what effect harmonizing to absolute path would have there on the code? |
@openMetadataInitiative/openminds-developers what is the verdict here? keeping extent path convention as is or making them all "absolute"? |
I don't see that the current convention causes any problem, so changing it would just create work for no gain. |
it's definitely not high priority and I don't care if we keep it or loose it as long as we validate for it in future, because we have created errors because of this convention in the past this said, I'm moving the issue to main (since it concerns all repos), and would suggest we keep it as is and do the following:
|
Paths should start with the “/” character or without. But we should not see both cases.
Non-exhaustive examples:
(Sample of schemas in openMINDS_SANDS)
Sample of “schemas/atlas/atlasAnnotation.schema.tpl.json”
Sample of “schemas/atlas/brainAtlas.schema.tpl.json”
The text was updated successfully, but these errors were encountered: