Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harmonize ontology identifier with Interlex #467

Open
aeidi89 opened this issue Sep 27, 2023 · 7 comments
Open

Harmonize ontology identifier with Interlex #467

aeidi89 opened this issue Sep 27, 2023 · 7 comments
Labels
request any request or update for schemas

Comments

@aeidi89
Copy link
Collaborator

aeidi89 commented Sep 27, 2023

Suggestion to change "preferredOntologyIdentifier" to a list of all ontologyIdentifiers, and thus harmonize with how it is displayed in Interlex (example link: https://neuinfo.org/interlex/view/ilx_0751626?searchTerm=alzheimer).

@apdavison
Copy link
Member

I don't understand the suggestion. Interlex only shows a single "preferred identifier". It has a list of all identifiers, but only one of them is marked as preferred.

@aeidi89
Copy link
Collaborator Author

aeidi89 commented Sep 27, 2023

That is true @apdavison, the idea is to have a list of 'ontologyIdentifiers', instead of or in addition to the 'preferredOntologyIdentifier'. This came from a case where openMINDS, Interlex and Knowledge Space all referred to different preferred ontology identifiers.

@apdavison
Copy link
Member

I agree it would be a good idea to add an array property ontologyIdentifier in addition to preferredOntologyIdentifier.

@lzehl
Copy link
Member

lzehl commented Jan 30, 2024

Fine with me. But this issue needs to move then to the repo where the schema is defined (openMINDS_controlledTerms).

@lzehl lzehl transferred this issue from openMetadataInitiative/openMINDS_instances Jan 30, 2024
@UlrikeS91 UlrikeS91 added question further information is requested request any request or update for schemas and removed question further information is requested labels May 8, 2024
@lzehl
Copy link
Member

lzehl commented Feb 3, 2025

TBD (@apdavison @tgbugs @UlrikeS91 @spieschnik @Raphael-Gazzotti ):

old

  • preferredOntologyIdentifier
  • InterLexIdentifier (THIS ONTOLOGY ID)
  • KnowledgeSpaceLink (IRI)

new?

  • ontologyIdentfier (one or list?)
  • KSLink (IRI) [or is this service link?]

@UlrikeS91
Copy link
Collaborator

I think it is generally good to reconsider how we organize these property names. I just need to make this a bit more complicated 😉

We need to additionally consider:
1. SANDS atlas schemas - They already have the property "ontologyIdentifier", which allows a single IRI. I'm not sure if these atlas elements could receive mulitple ontology IDs, but I guess they can? If it is generally the case, that an entity can have multiple ontology IDs assigned, we should always allow an array of IRIs. We can restrict it to a single one under "ontologyIdentifier" as well (instructions would specify that e.g., the preferred ID should be stated), but I do not see a got reason to mix this (i.e., allowing sometimes an array and somtimes only one IRI).

2. ControlledTerms terminologies linking to other resources as their "preferredOntologyIdentifier" - I just remembered this because of issue #174. There are several terminologies that link to Wikidata entries (found another example in OpertingDevices. Maybe we could consider these for the renaming as well? Either change the name of the property to include it somehow add a property to the ControlledTerms schemas?

Otherwise, I think it is accurate to consider KS links as service links. But I have a general question about this: Where do we draw the line for something to be considered a service? I feel like InterLex may also be considered a service. Is it not?

Sidenote, if we decide to use ServiceLinks, the schema needs updates to fit this purpose.

@lzehl
Copy link
Member

lzehl commented Feb 4, 2025

@openMetadataInitiative/openminds-developers

We may want to keep a single property for "ontologyIdentifier" which is an embedded schema providing the ID and the ontology service to use to extract that term from the ontology (entry point for queries in the ontology)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
request any request or update for schemas
Projects
None yet
Development

No branches or pull requests

4 participants