Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing properties for some instances: #153

Open
ehennestad opened this issue Jul 25, 2024 · 1 comment
Open

Missing properties for some instances: #153

ehennestad opened this issue Jul 25, 2024 · 1 comment
Assignees

Comments

@ehennestad
Copy link
Contributor

The following instances are defined with some missing properties:

Type: MolecularEntity, Instance name: iron, Missing property: "description".  
Type: MolecularEntity, Instance name: magnesiumChloride, Missing property: "description".  
Type: MolecularEntity, Instance name: magnesiumSulfate, Missing property: "description".  
Type: MolecularEntity, Instance name: nickel, Missing property: "description".  
Type: MolecularEntity, Instance name: potassiumGluconate, Missing property: "description".  
Type: MolecularEntity, Instance name: sodiumBicarbonate, Missing property: "description".  
Type: MolecularEntity, Instance name: sodiumChloride, Missing property: "description".  
Type: UBERONParcellation, Instance name: ansiformLobuleCrusI, Missing property: "definition".  
Type: UBERONParcellation, Instance name: ansiformLobuleCrusII, Missing property: "definition".  

I also propose to add a GitHub action that tests that all properties are present in instances on PRs

@ehennestad ehennestad self-assigned this Jul 25, 2024
@lzehl
Copy link
Member

lzehl commented Oct 8, 2024

thanks @ehennestad we are currently setting up and action that will cover validation for the future. Note though that these missing properties are not a violation of the schemas for those instances. It is just not following our openMINDS policy to add all properties so that we have a reminder what we still need to do/complement

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants