Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After P -> A -> B flow, OrderItems in B response are missing various properties including accessPass #120

Open
lukehesluke opened this issue Apr 27, 2021 · 5 comments
Assignees
Labels
approval-flow Needed for Approval Flow to work across test

Comments

@lukehesluke
Copy link
Contributor

lukehesluke commented Apr 27, 2021

Missing fields

  • position
  • (for virtual sessions)
    • accessChannel
    • customerNotice
  • (for physical sessions)
    • accessPass
    • accessCode
  • (not OrderItems but the Orders themselves):
    • totalPaymentTax (i haven't checked for all of them, but I can confirm that this was available in P's response - just not B. I expect they're all like that)
    • customer.identifier (it seems like all Customer fields excepting @type and email are missing from the B-after-P response)
    • customer.familyName
    • customer.givenName
    • customer.telephone
    • payment (therefore, payment reconcilliation tests fail)

An example failing test output:

access-channel_includes-access-channel-or-customer-notice_OpenBookingApprovalFlow_ScheduledSession.md

This error:

* ❌️ should include an `accessChannel` or a `customerNotice`
    - TypeError: Cannot read property 'accessChannel' of undefined

is because the test looks for OrderItem with position: 0 and it does not find it. The result has no position.

However, it also would have failed even still as the result has neither an accessChannel or a customerNotice - at least one of which is expected

This makes the following tests fail in Approval mode:

  • includes-access-channel-or-customer-notice
  • manual-access-codes
  • access-barcode-seller
  • access-pass-image
  • access-code-update-notifications
  • access-pass-update-notifications
  • customer-notice-notification
  • business-to-business-tax-calculation-net
  • business-to-consumer-tax-calculation-net
  • fail-outside-window
  • succeed-within-window
  • atomic-cancel
  • book-and-cancel
  • patch-contains-excessive-properties-error
  • patch-not-allowed-on-property-error
  • ...and some more
@lukehesluke lukehesluke added the approval-flow Needed for Approval Flow to work across test label Apr 27, 2021
@lukehesluke
Copy link
Contributor Author

I've added totalPaymentTax and customer.* fields to the missing properties above. Not sure if they're part of the same bug or something else

@lukehesluke lukehesluke changed the title After P -> A -> B flow, OrderItems in B response are missing various properties including position After P -> A -> B flow, OrderItems in B response are missing various properties including accessPass Apr 27, 2021
@lukehesluke
Copy link
Contributor Author

lukehesluke commented Apr 27, 2021

And I've removed position because it is correct that B-after-P does not return positions (openactive/open-booking-api#196)

@lukehesluke
Copy link
Contributor Author

Just added payment to the missing properties

@civsiv
Copy link
Contributor

civsiv commented Apr 29, 2021

Access fields covered by #124

@civsiv
Copy link
Contributor

civsiv commented Apr 30, 2021

Order field covered by #133

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval-flow Needed for Approval Flow to work across test
Projects
None yet
Development

No branches or pull requests

2 participants