Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capacity is not restored for replaced out OrderItems when an Order's OrderItems are replaced #167

Open
lukehesluke opened this issue Oct 7, 2021 · 0 comments

Comments

@lukehesluke
Copy link
Contributor

lukehesluke commented Oct 7, 2021

Assumption: When an Order's OrderItems are replaced, Opportunities which were previously in the Order but have been replaced OUT should have their capacity restored in the Opportunity feed

Here's an example test run demonstrating that this does not happen when using ReplacementSimulateAction:

seller-requested-replacement_book-and-seller-replace-items_OpenBookingSimpleFlow_ScheduledSession.md

The converse of this is: If a new Opportunity gets replaced IN to an Order, it's capacity should then decrease. I haven't tested this yet, but I expect that it will also fail in RefImpl


This was revealed while working on this Test Suite issue: openactive/openactive-test-suite#460

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant