Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LeaseOrderItems, BookOrdersItems, and ProposeOrderItems all replicate logic when should share it #226

Open
civsiv opened this issue Mar 28, 2024 · 0 comments
Open

LeaseOrderItems, BookOrdersItems, and ProposeOrderItems all replicate logic when should share it #226

civsiv opened this issue Mar 28, 2024 · 0 comments

Comments

@civsiv
Copy link
Contributor

civsiv commented Mar 28, 2024

In the FacilityStore and SessionStore, LeaseOrderItems, BookOrderItems, and ProposeOrderItems all replicate logic when should share it.
Furthermore the logic in ProposeOrderItems is directly copied from BookOrderItems and needs to be checked if it is correctly in the context of an OrderProposal instead of an Order.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@civsiv