Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contrast issue with the template footer text #23

Open
drinkynet opened this issue Nov 16, 2022 · 1 comment
Open

Contrast issue with the template footer text #23

drinkynet opened this issue Nov 16, 2022 · 1 comment

Comments

@drinkynet
Copy link
Contributor

The template footer text is overlayed directly on the body background and in the two examples there is an accessibility contrast error vs the default image background and the default gradient background.

The background image is configurable in settings so it can be set to something that doesn't cause the problem. But in the case of no image and falling back to the gradient background it would need a css change to fix.

Options to fix this are:

  • Choose an example image that doesn't cause the problem
  • Change the default gradient background to colours that don't cause the problem
  • Allow text colour to be set in the settings (would require also compiling the css)
  • Some other option :)

Screenshot 2022-11-16 at 15 57 26

Screenshot 2022-11-16 at 15 57 08

@nathansalter
Copy link
Contributor

I think the simplest option might be just add a box around the footer text with a consistent background so we can be sure that the BG image won't interfere

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants