Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix directory of generated files for PHP library #49

Closed
nickevansuk opened this issue Nov 25, 2021 · 2 comments
Closed

Fix directory of generated files for PHP library #49

nickevansuk opened this issue Nov 25, 2021 · 2 comments

Comments

@nickevansuk
Copy link
Contributor

Fix directory/references for generated files as noted here: openactive/models-php#79

Perhaps the issue is about the references rather than the directories?
@nickevansuk nickevansuk mentioned this issue Nov 25, 2021
Closed
@kjlloydie
Copy link

Potentially related: openactive/models-php#84 - the filename 3DModel.php is inconsistent with the naming of the ThreeDModel class, resulting in an inability to generate optimized autoload files in composer.

@chriscornford chriscornford mentioned this issue Mar 31, 2022
Merged
@nickevansuk nickevansuk mentioned this issue Mar 31, 2022
Open
@nickevansuk
Copy link
Contributor Author

Original issue closed by #55, @kjlloydie I've reraised your comment as a separate issue #56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
OpenActive Developer Documentation and Tooling Support
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kjlloydie @nickevansuk