Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alphabetical properties within classes #57

Open
nickevansuk opened this issue Apr 6, 2022 · 0 comments
Open

Alphabetical properties within classes #57

nickevansuk opened this issue Apr 6, 2022 · 0 comments

Comments

@nickevansuk
Copy link
Contributor

nickevansuk commented Apr 6, 2022

As this PR shows https://github.com/openactive/models-php/pull/89/files occassionally schema.org change the order of the source properties when they change their approach to generating their schema files.

When this happens the PR becomes bloated with reordering changes, which makes it much harder to find issues.

A simple solution to this is to sort the properties that are outputted by the generator alphabetically (as there is no inherent ordering to them in schema.org). This will ensure that they are not affected by such changes, and make it much easier to debug any resulting issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant