Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include default values in PHP and Ruby models #58

Open
nickevansuk opened this issue May 26, 2022 · 0 comments
Open

Include default values in PHP and Ruby models #58

nickevansuk opened this issue May 26, 2022 · 0 comments

Comments

@nickevansuk
Copy link
Contributor

nickevansuk commented May 26, 2022

For OpenBookingError subclasses and other cases where the model includes default values, these should be included in the PHP and Ruby libraries, as they are currently in .NET:

.NET Library:
https://github.com/openactive/OpenActive.NET/blob/dc4514c0c3ca1b57a71528d1c46386f2c6200f12/OpenActive.NET/models/IncompleteCustomerDetailsError.cs#L62-L69

PHP Library:
https://github.com/openactive/models-php/blob/785bfc5d0d06e2d4191033833e67f4aa7ec7b265/src/Models/OA/IncompleteCustomerDetailsError.php#L42-L50

Ruby Library:
https://github.com/openactive/models-ruby/blob/e745ea93084c6d9a4bfa1b28f41e85cd172893bc/lib/openactive/models/incomplete_customer_details_error.rb#L3-L24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant