Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validator and OpenActive.Net disagree on allowable values of "kind" #23

Open
matdavies opened this issue Jun 14, 2021 · 2 comments
Open

Comments

@matdavies
Copy link

OpenActive.Net serialises the "kind" field for slots as "Slot":

https://github.com/openactive/OpenActive.NET/blob/b171a1c76184b6d69118483bd998dab3eea29907/OpenActive.NET/rpde/RDPEModels.cs#L47

https://github.com/openactive/OpenActive.NET/blob/b171a1c76184b6d69118483bd998dab3eea29907/OpenActive.NET/rpde/RDPEModels.cs#L338

(Though I must admit, I can't seem to find where this property is actually set?)

However, the validator does not accept this type:

Given this array of items, this is the result;

image

@nickevansuk
Copy link
Contributor

Ah in OA.NET it should be FacilityUseSlot instead of Slot that's used

@matdavies
Copy link
Author

Ah, ok. Why is slot even in there BTW? If that "kind" is not a valid kind, why is it in the enum at all?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants