Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing loss mask with hierarchical action space in behavior cloning script? #26

Open
phython96 opened this issue Feb 28, 2023 · 1 comment
Labels
question Further information is requested

Comments

@phython96
Copy link

Hi, I found that finetuning foundation-model-1x starts with a high loss (14.0) using find-cave contractor data.
As described in section E.3, when using hierarchical action space, loss for the secondary mouse movement should be masked during training.
However, I didn't find the implementation in behavior_cloning.py, which may be the reason why the fintuning loss is large.
Looking forward to your reply, thanks.

@phython96 phython96 changed the title Missing loss mask with hierarchical action space in behavior cloning script Missing loss mask with hierarchical action space in behavior cloning script? Feb 28, 2023
@Miffyli
Copy link
Collaborator

Miffyli commented Mar 6, 2023

Hey! Sorry for the delay; I have been OOF :)

Hmm can you pinpoint the phrase about "secondary mouse movement"? The action space should capture mouse movement regardless of the task/setup.

The high loss is also probably due to to different training setup; due to memory constraints, the BC example trains with very small sequences lengths (and one sample at a time). The behaviour of the players in the find-cave (or other BASALT task) is also significantly different from general Minecraft gameplay, so I am not that surprised the loss starts high.

@Miffyli Miffyli added the question Further information is requested label Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants