Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Valence methods rename proposal #9

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

baoilleach
Copy link
Member

@baoilleach baoilleach commented Apr 20, 2019

@ghutchis
Copy link
Member

I think I'd keep the 'Get' part, but I'm not sure why you'd want to call some of them Calc and some of them Get. I'd go with 'Get' for all of them, so you don't need to think 'oh was this a Calc or a Get method' when you're programming.

@baoilleach
Copy link
Member Author

baoilleach commented Apr 21, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants