[Release 8] Studio group #340
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferishili
added
enhancement
chfsx
reviewed
Aug 23, 2024
chfsx
requested changes
Aug 23, 2024
There was a problem hiding this comment.
Hi @ferishili and thanks a lot for the PR! please have a look at the inline comments and questions.
|
Hi @chfsx, I've answered all the questions and comments. Please take a look and let me know if a VC would help to clarify this PR! Thanks |
ferishili
added
the
Ready to merge
|
Hi @chfsx, |
|
We did not yet have time to test this PR properly. Our goal is to test it in the next 2-3 weeks. |
dagraf
removed
the
Ready to merge
|
Hi @dagraf |
|
I passed testing to a colleague here since I do not have time to test it. I will get back to you as soon as possible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #339
What is new
addCurrentUserToProducermethod is now optimized to support different groups and it is renamed toaddCurrentUserToGroupThis PR might get updated...