Skip to content
This repository has been archived by the owner on Mar 12, 2024. It is now read-only.

Various NaN values in predictions #50

Open
flowirtz opened this issue Feb 10, 2021 · 1 comment
Open

Various NaN values in predictions #50

flowirtz opened this issue Feb 10, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@flowirtz
Copy link
Contributor

Hey @tomwhite, I just got around to run predict from your work in f1812ff to get it deployed on AWS. One thing I noticed is that the Zarr file that you use in the predict_test produces a bunch of NaN values in the resulting GeoJSON.

e.g.

{
    "type": "Feature",
    "geometry": {
        "type": "Point",
        "coordinates": [
            -0.07,
            52.33
        ]
    },
    "properties": {
        "system_id": 1883,
        "time": "2020-09-08T13:00:00",
        "pv_yield_predicted": NaN
    }
},

It's no biggie - apparently NaN is fine in JS, just not valid JSON - but I'd like to understand where they come from and if we can get rid of them. I did check whether the system_id doesn't exist in the model, but it does.

Do you have any ideas?

@flowirtz flowirtz added the bug Something isn't working label Feb 10, 2021
@flowirtz
Copy link
Contributor Author

I changed it so that the NaNs get replaced with null, but still not sure where they come from 🤔

"pv_yield_predicted": None if math.isnan(row["pv_yield_predicted"]) else row["pv_yield_predicted"],

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant