Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove "site" from SiteBatchkey #79

Closed
peterdudfield opened this issue Nov 7, 2024 · 1 comment
Closed

remove "site" from SiteBatchkey #79

peterdudfield opened this issue Nov 7, 2024 · 1 comment
Assignees
Labels
good first issue Good for newcomers

Comments

@peterdudfield
Copy link
Contributor

peterdudfield commented Nov 7, 2024

It would be good to remove the extra work fo site fomr the SitebatchKey

https://github.com/openclimatefix/ocf-data-sampler/blob/main/ocf_data_sampler/numpy_batch/site.py#L9

Other bits of code would also need updating. So site_capacity_kwp = "site_capacity_kwp" would go to
capacity_kwp = "site_capacity_kwp"

@peterdudfield peterdudfield added the good first issue Good for newcomers label Nov 7, 2024
@alirashidAR
Copy link
Contributor

Hi @peterdudfield,

I’ve been exploring the organization’s projects and, to gain a better understanding, I’d like to contribute by resolving some smaller issues. Would it be okay if I take this up?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants