Option to raise error if 1 site fails

[peterdudfield]

it would be good to raise an error if 1 sites fails

This could be done here

In the future we might want to group sites, so only raise an error, if critical sites fail

[Clemo97]

Hey @peterdudfield,
Happy New Year 🎉.
I'm working on this issue and want some clarification.
So an error should be raised the moment a pv site processing fails, thus stoping the main execution flow, or should it just store all the failures and then raise an error once all pv site processing is done?

[peterdudfield]

Yea, store all failures, but carry on running. Then if num_successes>0 then it fails.
It would be great if this was optional and a environmental variable could turn this on or off.

[Clemo97]

That sounds like a good idea.
How about using the already implemented click library.
The user could add an argument at the end of the run command poetry run python forecast_inference/app.py --raise-on-failure

What do you think about this?

[peterdudfield]

That sounds like a good idea. How about using the already implemented click library. The user could add an argument at the end of the run command poetry run python forecast_inference/app.py --raise-on-failure

What do you think about this?

great idea