Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback: API inconsistencies #160

Open
dctanner opened this issue Oct 12, 2022 · 1 comment
Open

Feedback: API inconsistencies #160

dctanner opened this issue Oct 12, 2022 · 1 comment

Comments

@dctanner
Copy link
Contributor

  1. gsp: 0 is used for the national forecast. However when requesting https://api.nowcasting.io/v0/solar/GB/national/pvlive it returns gsp: null instead of gsp: 0
  2. Different energy units are used in different endpoints. E.g. https://api.nowcasting.io/v0/solar/GB/national/forecast returns values in Mw, but https://api.nowcasting.io/v0/solar/GB/national/pvlive returns them in Kw.
@dctanner dctanner added the enhancement New feature or request label Oct 12, 2022
@peterdudfield
Copy link
Collaborator

For 1. I can fix that, but I wondering what the correct value should be. In the past gsp=0 for national was confusing, so is gsp=null actually better. Or perhaps the better solution is to remove the gsp field for this.

  1. That has grown up from PVlive giving the data in kw and most pv system wokring in kw. But the forecast seem right to give in mw. particualy the national would seem a bit funny in kw / slash harder to read. Its quite some task to change things in the back end (but possible), perhaps the simple solution is to just change pvlive to MW in the api.

What do you think?

@peterdudfield peterdudfield removed the enhancement New feature or request label Oct 12, 2022
@peterdudfield peterdudfield moved this to Todo in Nowcasting WP3 Oct 12, 2022
@peterdudfield peterdudfield changed the title API inconsistencies Feedback: API inconsistencies Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Todo
Development

No branches or pull requests

2 participants