Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the bug with the annotation and few fixme's #24

Merged
merged 1 commit into from
Aug 28, 2024
Merged

Conversation

sksekar
Copy link
Collaborator

@sksekar sksekar commented Aug 28, 2024

Prior this change, the "annotation" printed for each group was the same. With this change, the annotation is derived from the group name (see snapshot below). This also fixes few "fixme's"

[root@dut /tmp]# time ./pci_lmt.par -o json -c lmt.cfg.org auto |  jq -rc '[.test_info.annotation, .device_info.bdf, .lane, .step, .error_count]' | grep -v ",0]"
["CPU Tx -> Retimer Rx (Timing left)","0000:00:01.1",0,6,63]
["CPU Tx -> Retimer Rx (Timing left)","0000:00:01.1",1,6,54]
:
["Retimer Tx -> PEX Rx (Timing left)","0000:01:00.0",3,16,1]
["Retimer Tx -> PEX Rx (Timing left)","0000:e1:00.0",7,16,1]
:
["PEX Tx -> ASIC Rx (Timing right)","0000:09:00.0",0,15,1]
["PEX Tx -> ASIC Rx (Timing right)","0000:0a:00.0",3,15,2]

@sksekar sksekar self-assigned this Aug 28, 2024
@sksekar sksekar requested a review from mimir-d August 28, 2024 08:59
else:
lane_result.margin_type += "none"
if self.margin_type == "TIMING":
lane_result.margin_type = get_timing_margin_type_as_str()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i suggest using proper types and the type checker instead of labeling methods with types (here x_as_str())

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the approval. Will address in the next PR (need some time to learn more about the enum types and how it can be used here)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that too, yes; the string "TIMING" should be an enum type

@sksekar sksekar merged commit 688c6e9 into dev Aug 28, 2024
5 checks passed
@sksekar sksekar deleted the bugfix/annotation branch August 28, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants