diff --git a/feature/gribi/otg_tests/hierarchical_weight_resolution_pbf_test/hierarchical_weight_resolution_pbf_test.go b/feature/gribi/otg_tests/hierarchical_weight_resolution_pbf_test/hierarchical_weight_resolution_pbf_test.go index 14e31ed3229..bde47271652 100644 --- a/feature/gribi/otg_tests/hierarchical_weight_resolution_pbf_test/hierarchical_weight_resolution_pbf_test.go +++ b/feature/gribi/otg_tests/hierarchical_weight_resolution_pbf_test/hierarchical_weight_resolution_pbf_test.go @@ -295,7 +295,7 @@ func (a *attributes) configInterfaceDUT(t *testing.T, d *ondatra.DUTDevice) { a.configSubinterfaceDUT(t, i, d) intfPath := gnmi.OC().Interface(p.Name()) - gnmi.Replace(t, d, intfPath.Config(), i) + gnmi.Update(t, d, intfPath.Config(), i) fptest.LogQuery(t, "DUT", intfPath.Config(), gnmi.Get(t, d, intfPath.Config())) } diff --git a/internal/core/core.go b/internal/core/core.go index 438c646b297..20f0032fccf 100644 --- a/internal/core/core.go +++ b/internal/core/core.go @@ -20,6 +20,7 @@ package core import ( "bytes" "context" + "errors" "fmt" "regexp" "sync" @@ -212,7 +213,7 @@ func registerAfter(_ *eventlis.AfterTestsEvent) error { glog.Infof(msg) ondatra.Report().AddSuiteProperty("validator.core.end", report) if foundCores { - return fmt.Errorf(msg) + return errors.New(msg) } return nil } diff --git a/tools/internal/ocpaths/ocpaths_test.go b/tools/internal/ocpaths/ocpaths_test.go index f4582df917f..237e8947b59 100644 --- a/tools/internal/ocpaths/ocpaths_test.go +++ b/tools/internal/ocpaths/ocpaths_test.go @@ -164,7 +164,7 @@ func TestValidatePath(t *testing.T) { err := validatePath(ocpath, root) if diff := errdiff.Substring(err, tt.wantErrSubstr); diff != "" { - t.Errorf(diff) + t.Error(diff) } if err != nil {