internal/deviations/deviations.go is ... playing a risk game of roullete.

[morrowc]

Describe the bug

deviations.go is full of this pattern:
for _, platformExceptions := range metadata.Get().PlatformExceptions

which is effectively: "Here's a struct with a safe get/set method, but heck I'll just reach in there and .. boom panic" :(

To Reproduce

Don't know! :) but intenral testing blows up all over this, and simple proto/golang rules say: "never do this, cause boom panic!"

Expected behavior

do not panic ?

Logs

runtime error: invalid memory address or nil pointer dereference [recovered]
	panic: runtime error: invalid memory address or nil pointer dereference

are these REALLY needed here? Nope cause this is super clearly wrong.

Network device platform (please complete the following information):

anything that touches this code path is gonna have a bad day

Additional context

nope?

[morrowc]

Apparently I don't now how to link PRs with Issues :(
PR: #3570
was created and merged for this issue.