Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes: 1) time.Duration function wrong unit; 2) transceiver disable OC path #3672

Merged
merged 2 commits into from
Jan 2, 2025

Conversation

jianchen-g
Copy link
Contributor

bug fixes: 1) in zr_laser_bias_current_test file, the time.Duration function returns value in nanosecond by default, needs to convert it to second; 2) in zr_low_power_mode_test file, to use the transceiver disable OC path, the input needs to be transceiver name instead of interface name.

…unction returns value in nanosecond by default, needs to convert it to second; 2) in zr_low_power_mode_test file, to use the transceiver disable OC path, the input needs to be transceiver name instead of interface name.
@jianchen-g jianchen-g requested a review from a team as a code owner December 27, 2024 21:51
@OpenConfigBot
Copy link

OpenConfigBot commented Dec 27, 2024

Pull Request Functional Test Report for #3672 / 8e22162

Virtual Devices

Device Test Test Documentation Job Raw Log
Arista cEOS status
status
TRANSCEIVER-13: Configuration: 400ZR Transceiver Low Power Mode Setting.
TRANSCEIVER-9: Telemetry: 400ZR TX laser bias current telemetry values streaming.
Cisco 8000E status
status
TRANSCEIVER-13: Configuration: 400ZR Transceiver Low Power Mode Setting.
TRANSCEIVER-9: Telemetry: 400ZR TX laser bias current telemetry values streaming.
Cisco XRd status
status
TRANSCEIVER-13: Configuration: 400ZR Transceiver Low Power Mode Setting.
TRANSCEIVER-9: Telemetry: 400ZR TX laser bias current telemetry values streaming.
Juniper ncPTX status
status
TRANSCEIVER-13: Configuration: 400ZR Transceiver Low Power Mode Setting.
TRANSCEIVER-9: Telemetry: 400ZR TX laser bias current telemetry values streaming.
Nokia SR Linux status
status
TRANSCEIVER-13: Configuration: 400ZR Transceiver Low Power Mode Setting.
TRANSCEIVER-9: Telemetry: 400ZR TX laser bias current telemetry values streaming.
Openconfig Lemming status
status
TRANSCEIVER-13: Configuration: 400ZR Transceiver Low Power Mode Setting.
TRANSCEIVER-9: Telemetry: 400ZR TX laser bias current telemetry values streaming.

Hardware Devices

Device Test Test Documentation Raw Log
Arista 7808 status
status
TRANSCEIVER-13: Configuration: 400ZR Transceiver Low Power Mode Setting.
TRANSCEIVER-9: Telemetry: 400ZR TX laser bias current telemetry values streaming.
Cisco 8808 status
status
TRANSCEIVER-13: Configuration: 400ZR Transceiver Low Power Mode Setting.
TRANSCEIVER-9: Telemetry: 400ZR TX laser bias current telemetry values streaming.
Juniper PTX10008 status
status
TRANSCEIVER-13: Configuration: 400ZR Transceiver Low Power Mode Setting.
TRANSCEIVER-9: Telemetry: 400ZR TX laser bias current telemetry values streaming.
Nokia 7250 IXR-10e status
status
TRANSCEIVER-13: Configuration: 400ZR Transceiver Low Power Mode Setting.
TRANSCEIVER-9: Telemetry: 400ZR TX laser bias current telemetry values streaming.

Help

@coveralls
Copy link

coveralls commented Dec 27, 2024

Pull Request Test Coverage Report for Build 12588200469

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 55.268%

Totals Coverage Status
Change from base Build 12578858218: 0.0%
Covered Lines: 1983
Relevant Lines: 3588

💛 - Coveralls

Copy link
Contributor

@Ankur19 Ankur19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jianchen-g jianchen-g requested a review from amrindrr January 2, 2025 20:23
@dplore dplore merged commit f22501d into main Jan 2, 2025
16 checks passed
@dplore dplore deleted the jianchen-g/OC_github branch January 2, 2025 23:16
ampattan pushed a commit to nokia/featureprofiles that referenced this pull request Jan 17, 2025
…unction returns value in nanosecond by default, needs to convert it to second; 2) in zr_low_power_mode_test file, to use the transceiver disable OC path, the input needs to be transceiver name instead of interface name. (openconfig#3672)

Co-authored-by: anksaiki <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants