New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

in layer2.proto file simple string could be fine instead of types.Path . It is to clear lldp interface adjacency and not for config or streaming anything out side. #133

Open

jatinvd opened this issue Feb 1, 2023 · 0 comments

jatinvd commented Feb 1, 2023

from https://github.com/openconfig/gnoi/blob/main/layer2/layer2.proto

message ClearLLDPInterfaceRequest {
types.Path interface = 1;
}
===> this message is only meant to clear LLDP adjacency on the provided interface.

Now why to make it complicated as this is not used for any other purpose like streaming ?

can we have it as simple string?

example:
message ClearLLDPInterfaceRequest {
string interface = 1;
}

This makes more sense i think.

jatinvd changed the title ~~in layer2.proto file simple string could be fine instead of types.Path . it is only menat to clear lldp interface and not for streaming anything out side.~~ in layer2.proto file simple string could be fine instead of types.Path . It is to clear lldp interface adjacency and not for config or streaming anything out side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment