Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move misc-checks logic into openconfig-ci #96

Open
wenovus opened this issue Nov 30, 2023 · 0 comments
Open

Move misc-checks logic into openconfig-ci #96

wenovus opened this issue Nov 30, 2023 · 0 comments
Assignees

Comments

@wenovus
Copy link
Contributor

wenovus commented Nov 30, 2023

Currently, misc-checks is done via file-message-passing to post_results. This is not ideal since message passing via files is less testable and requires more work (annoying to write text files and define the message-passing format), and is as a result more error-prone and makes new checks harder to add.

For example, if I wanted to add a more precise type check for backwards-incompatibilities, then the right place to put it is the openconfig-ci tool breaking-check checker. However I would need to generate a text file in order to merge it with the "Major version updates in commit xx" message so as to not clutter the PR. This adds to the complexity of the CI system.

A better way is to just have a single tool that does all of the openconfig CI checks. Any failures would be recorded, and any messages about potential breaking changes, and "Major version updates in commit xx", or other future informative messages can be recorded there without having to deal with message passing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant