[BYON] Show/hide ImageStreams imported through BYON/ODH Dashboard

[tumido]

BYON implements new annotations for imagestreams that allow them to be conditionally shown/hidden from the Spawner UI.

open-services-group/byon#18

opendatahub.io/notebook-image-visible is either true or false. Show only those images which have this value set to true.

For compatibility with current/previous releases of ODH we can either default to show the image stream if this annotation is not present at all, or use additional opendatahub.io/notebook-image-origin annotation to track if the image is produced by BYON...

[tumido]

/cc @guimou @LaVLaS

As @guimou correctly mentioned yesterday on the BYON meeting, we may want to reconsider usage of the opendatahub.io/notebook-image: 'true' label. Initially we've introduced additional label for visibility in open-services-group/byon#18 since I thought we needed to have 2 distinct labels because each had different usage. Right now it seems to me that this is not necessarily true and we may be better of using only the opendatahub.io/notebook-image for visibility toggle... Did I miss anything?

Let's say the full cycle is:

stateDiagram-v2
   A: Import starts
   C: Validation Starts
   B: ImageStream is created (without #96;opendatahub.io#47;notebook#dash;image#96; label)
   D: Validation Passes
   E: Validation Fails
   F: Add label #96;opendatahub.io#47;notebook#dash;image#colon; #quot;true#quot;#96; to ImageStream
   G: Import done
   [*] --> A
   A --> B
   state Validation <<choice>>
   B --> C
   C --> Validation
   Validation --> D
   Validation --> E
   D --> F
   F --> G
   E --> G
   G --> [*]

Loading

Adopting this cycle we don't have to change anything in the Spawner UI, only slight modifications are required in BYON pipelines and ODH Dashboard backend for BYON.

I don't think it can get much simpler and I don't see any reason to insist on introducing the additional annotation... WDYT?

[guimou]

Seems fair and more than enough for a first release.
Other options we discussed yesterday, like having a specific group (reviewers, admins?) only seeing new images for validation purposes for example, is more of a nice to have. And anyway they could/should do this in a Dev environment where only them have access.
So I'd keep it as simple as possible for the moment, exactly as you described.
Plus no need to disturb up the Spawner UI code that we'll deprecate in a few anyway. Better for everyone.