Skip to content
This repository has been archived by the owner on Mar 17, 2023. It is now read-only.

Implement support for defining additional volumes in profiles #80

Closed
4 tasks done
vpavlin opened this issue Jan 13, 2021 · 4 comments · Fixed by #81
Closed
4 tasks done

Implement support for defining additional volumes in profiles #80

vpavlin opened this issue Jan 13, 2021 · 4 comments · Fixed by #81
Assignees
Labels
enhancement New feature or request

Comments

@vpavlin
Copy link
Contributor

vpavlin commented Jan 13, 2021

Example profile:

- name: globals
    env:
    - name: THIS_IS_GLOBAL
      value: "This will appear in all singleuser pods"
    resources:
      requests:
        memory: "500Mi"
        cpu: "250m"
      limits:
        memory: "1Gi"
        cpu: "500m"
    volumes:
    - name: dataset
      persistentVolumeClaim:
        claimName: example-dataset-pvc
      mountPath(1): /opt/app-root/src/example-dataset
      mountPaht(2): ./example-dataset (add prefix)
      (3) no-mountPath: /opt/app-root/src/$(name)

References:

Implements first use case of #38

@nakfour
Copy link

nakfour commented Jan 14, 2021

How can we inform the user that volumes that are not multi-read-write will not work?

@maroroman
Copy link
Contributor

Volumes that are not multi-read-write will just fail for now, because we don't really have a good way of informing the administrator currently.

@vpavlin
Copy link
Contributor Author

vpavlin commented Jan 18, 2021

@YiannisGkoufas FYI, we are working on this issue, which will allow us to mount arbitrary RWX PVC in the user pods. I think this basically takes us just one step from being able to leverage DLF.

@YiannisGkoufas
Copy link

Great @vpavlin ! Let me know (or open an issue) if there is something needed from the DLF side.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants