Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sample IR files generated as a result of testing. #18

Closed
wants to merge 2 commits into from

Conversation

amadhusu
Copy link

@amadhusu amadhusu commented Feb 16, 2024

Description of your changes:
These sample IR files were generated as part of testing sample pipelines against DSPv2 at https://issues.redhat.com/browse/RHOAIENG-2880
This PR can be closed if these IR files aren't required and just unnecessary.

Testing:
There is nothing to test as this PR is just the IR files generated from the sample python files which are already part of this code base.

Checklist:

Copy link

openshift-ci bot commented Feb 16, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: amadhusu
Once this PR has been reviewed and has the lgtm label, please assign dharmitd for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dsp-developers
Copy link

A set of new images have been built to help with testing out this PR:
API Server: quay.io/opendatahub/ds-pipelines-api-server:pr-18
DSP DRIVER: quay.io/opendatahub/ds-pipelines-driver:pr-18
DSP LAUNCHER: quay.io/opendatahub/ds-pipelines-launcher:pr-18
Persistence Agent: quay.io/opendatahub/ds-pipelines-persistenceagent:pr-18
Scheduled Workflow Manager: quay.io/opendatahub/ds-pipelines-scheduledworkflow:pr-18
MLMD Server: quay.io/opendatahub/ds-pipelines-metadata-grpc:pr-18
MLMD Envoy Proxy: quay.io/opendatahub/ds-pipelines-metadata-envoy:pr-18
UI: quay.io/opendatahub/ds-pipelines-frontend:pr-18

@dsp-developers
Copy link

An OCP cluster where you are logged in as cluster admin is required.

The Data Science Pipelines team recommends testing this using the Data Science Pipelines Operator. Check here for more information on using the DSPO.

To use and deploy a DSP stack with these images (assuming the DSPO is deployed), first save the following YAML to a file named dspa.pr-18.yaml:

apiVersion: datasciencepipelinesapplications.opendatahub.io/v1alpha1
kind: DataSciencePipelinesApplication
metadata:
  name: pr-18
spec:
  dspVersion: v2
  apiServer:
    image: "quay.io/opendatahub/ds-pipelines-api-server:pr-18"
    argoDriverImage: "quay.io/opendatahub/ds-pipelines-driver:pr-18"
    argoLauncherImage: "quay.io/opendatahub/ds-pipelines-launcher:pr-18"
  persistenceAgent:
    image: "quay.io/opendatahub/ds-pipelines-persistenceagent:pr-18"
  scheduledWorkflow:
    image: "quay.io/opendatahub/ds-pipelines-scheduledworkflow:pr-18"
  mlmd:  
    deploy: true  # Optional component
    grpc:
      image: "quay.io/opendatahub/ds-pipelines-metadata-grpc:pr-18"
    envoy:
      image: "quay.io/opendatahub/ds-pipelines-metadata-envoy:pr-18"
  mlpipelineUI:
    deploy: true  # Optional component 
    image: "quay.io/opendatahub/ds-pipelines-frontend:pr-18"
  objectStorage:
    minio:
      deploy: true
      image: 'quay.io/opendatahub/minio:RELEASE.2019-08-14T20-37-41Z-license-compliance'

Then run the following:

cd $(mktemp -d)
git clone [email protected]:opendatahub-io/data-science-pipelines.git
cd data-science-pipelines/
git fetch origin pull/18/head
git checkout -b pullrequest 17c7f1e13fe9020e596e656c124aa5d30b77b296
oc apply -f dspa.pr-18.yaml

More instructions here on how to deploy and test a Data Science Pipelines Application.

@dsp-developers
Copy link

Change to PR detected. A new PR build was completed.
A set of new images have been built to help with testing out this PR:
API Server: quay.io/opendatahub/ds-pipelines-api-server:pr-18
DSP DRIVER: quay.io/opendatahub/ds-pipelines-driver:pr-18
DSP LAUNCHER: quay.io/opendatahub/ds-pipelines-launcher:pr-18
Persistence Agent: quay.io/opendatahub/ds-pipelines-persistenceagent:pr-18
Scheduled Workflow Manager: quay.io/opendatahub/ds-pipelines-scheduledworkflow:pr-18
MLMD Server: quay.io/opendatahub/ds-pipelines-metadata-grpc:pr-18
MLMD Envoy Proxy: quay.io/opendatahub/ds-pipelines-metadata-envoy:pr-18
UI: quay.io/opendatahub/ds-pipelines-frontend:pr-18

1 similar comment
@dsp-developers
Copy link

Change to PR detected. A new PR build was completed.
A set of new images have been built to help with testing out this PR:
API Server: quay.io/opendatahub/ds-pipelines-api-server:pr-18
DSP DRIVER: quay.io/opendatahub/ds-pipelines-driver:pr-18
DSP LAUNCHER: quay.io/opendatahub/ds-pipelines-launcher:pr-18
Persistence Agent: quay.io/opendatahub/ds-pipelines-persistenceagent:pr-18
Scheduled Workflow Manager: quay.io/opendatahub/ds-pipelines-scheduledworkflow:pr-18
MLMD Server: quay.io/opendatahub/ds-pipelines-metadata-grpc:pr-18
MLMD Envoy Proxy: quay.io/opendatahub/ds-pipelines-metadata-envoy:pr-18
UI: quay.io/opendatahub/ds-pipelines-frontend:pr-18

@HumairAK
Copy link

Let's not add them here, this would become a carried patch, and this is not the location where we want to add them (though we can propose this upstream first to also include the yaml files)

@HumairAK HumairAK closed this Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants