Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update all text items and field labels on Notebook images table #1432

Closed
DaoDaoNoCode opened this issue Jun 26, 2023 · 5 comments · Fixed by #1506
Closed

Update all text items and field labels on Notebook images table #1432

DaoDaoNoCode opened this issue Jun 26, 2023 · 5 comments · Fixed by #1506
Assignees
Labels
feature/byon Bring Your Own Notebook Feature priority/high Important issue that needs to be resolved asap. Releases should not have too many of these.

Comments

@DaoDaoNoCode
Copy link
Member

DaoDaoNoCode commented Jun 26, 2023

Goal

Make sure the text items and fields the same as the mock up listed as below

Dependency issue

Tracker: #1254

Itemized goals

  • Change the nav item title
  • Change the page description
  • Use the generic table component
  • Add a helper tooltip for the Enable field on the custom image table
  • Change the expandable section UI to align with the design

Aspects continued elsewhere

Update all text items and field labels on Notebook images modals (Import, Edit, Delete) - ticket TBD

Mocks

image

@DaoDaoNoCode DaoDaoNoCode added the priority/high Important issue that needs to be resolved asap. Releases should not have too many of these. label Jun 26, 2023
@github-project-automation github-project-automation bot moved this to Needs prioritization in ODH Dashboard Planning Jun 26, 2023
@DaoDaoNoCode DaoDaoNoCode added the feature/byon Bring Your Own Notebook Feature label Jun 26, 2023
@DaoDaoNoCode DaoDaoNoCode moved this from Needs prioritization to To do in ODH Dashboard Planning Jun 26, 2023
@DaoDaoNoCode DaoDaoNoCode moved this from To do to In progress in ODH Dashboard Planning Jul 10, 2023
@DaoDaoNoCode DaoDaoNoCode self-assigned this Jul 10, 2023
@DaoDaoNoCode
Copy link
Member Author

We will not add To change the order... in the description before we reach phase 2 because we will not implement the drag and drop feature in phase 1. cc @vconzola @kaedward Can we just set the description as Manage your notebook images. when we don't have drag and drop for now or do you think there are more descriptions we can add?

@vconzola
Copy link

@DaoDaoNoCode Yes, omitting the rest of the description, leaving "Manage your notebook images." is fine for phase 1.

@DaoDaoNoCode
Copy link
Member Author

@vconzola Cool, thanks. BTW, what do we want to search in the filters? I think the Name, Description, and Provider should be enough, right?

@vconzola
Copy link

@DaoDaoNoCode Yes, that sounds good for the filters. And since were' not doing drag and drop in phase 1, be sure to keep the existing column sorting.

@DaoDaoNoCode DaoDaoNoCode linked a pull request Jul 12, 2023 that will close this issue
7 tasks
@DaoDaoNoCode DaoDaoNoCode moved this to In progress in ODH Dashboard Planning Jul 17, 2023
@DaoDaoNoCode DaoDaoNoCode moved this from In progress to Done in ODH Dashboard Planning Jul 17, 2023
@manosnoam
Copy link
Contributor

Verified on RHODS 2.4:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/byon Bring Your Own Notebook Feature priority/high Important issue that needs to be resolved asap. Releases should not have too many of these.
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants