Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update all text items and field labels in modals #1433

Closed
DaoDaoNoCode opened this issue Jun 26, 2023 · 3 comments · Fixed by #1529
Closed

Update all text items and field labels in modals #1433

DaoDaoNoCode opened this issue Jun 26, 2023 · 3 comments · Fixed by #1529
Assignees
Labels
feature/byon Bring Your Own Notebook Feature priority/high Important issue that needs to be resolved asap. Releases should not have too many of these.

Comments

@DaoDaoNoCode
Copy link
Member

DaoDaoNoCode commented Jun 26, 2023

Goal

Make sure the text items and fields the same as the mock up listed as below

Dependency issue

Tracker: #1254

Itemized goals

  • Modify the fields in the manage notebook images modal to align with the mockup (title, field label, empty state, helper text)
  • Add a helper tooltip for Image location (the field label is Repository now, tooltip content TBD)
  • Refactor the adding packages and adding software part. Now it's 2 icons instead of 3 icons with different user interactions design
  • Use the generic delete modal to delete the custom notebook images

Aspects continued elsewhere

No response

Mocks

  • Change modal headline to "Import notebook image" - no "s"

  • Change field label to "Image location" and add helper text

  • Add a field label, "Displayed contents", above the Software and Packages tabs

  • Change empty state icon to plus sign

  • Change empty state text as shown
    image

  • Add a popover showing formats for various location examples
    image

  • when user clIcks Add software, insert a one row table as shown with the text fields empty and the Software textbox in focus with the cursor

  • When editing is complete, selecting the check icon closes the row for editing. The textbox contents are displayed in simple text in the row. The check and cancel icons are replaced with edit and remove icons. Selecting cancel while in edit state closes the row for editing and discards any changes made to the text fields.

  • Selecting the remove (-) icon deletes the current table row. No validation required. If there is only one row in the table, remove deletes the table and returns user to the empty state

  • The user can add as many rows to the table as they want by selecting the Add software link button. Focus moves to the just added row

  • If the user selects the Import button any row with a blank Software field is ignored and not saved
    image

@DaoDaoNoCode DaoDaoNoCode added priority/high Important issue that needs to be resolved asap. Releases should not have too many of these. feature/byon Bring Your Own Notebook Feature labels Jun 26, 2023
@github-project-automation github-project-automation bot moved this to Needs prioritization in ODH Dashboard Planning Jun 26, 2023
@DaoDaoNoCode DaoDaoNoCode moved this from Needs prioritization to To do in ODH Dashboard Planning Jun 26, 2023
@DaoDaoNoCode DaoDaoNoCode self-assigned this Jul 13, 2023
@DaoDaoNoCode DaoDaoNoCode moved this from To do to In progress in ODH Dashboard Planning Jul 13, 2023
@DaoDaoNoCode DaoDaoNoCode linked a pull request Jul 17, 2023 that will close this issue
7 tasks
@github-project-automation github-project-automation bot moved this from In progress to Done in ODH Dashboard Planning Jul 31, 2023
@manosnoam
Copy link
Contributor

@DaoDaoNoCode Can you add the requirments as shown on the screenshots (text on the right side) ?
This can be used for verification purpose to describe the required tests. Thanks!

@DaoDaoNoCode
Copy link
Member Author

@manosnoam Updated, please make sure you also refer to the description and test instructions in the PR because the implementation could be slightly different sometimes when we had the discussion in the development with the designers.

@manosnoam
Copy link
Contributor

Thanks @DaoDaoNoCode verified on release 2.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/byon Bring Your Own Notebook Feature priority/high Important issue that needs to be resolved asap. Releases should not have too many of these.
Projects
Status: No status
Status: No status
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants