Prevent Jackson from unwrapping List in Geometry #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a Geometry containing a single list of LngLatAlt within its coordinates list was serialized using an ObjectMapper with SerializationFeature.WRITE_SINGLE_ELEM_ARRAYS_UNWRAPPED enabled the resulting output no longer matched the examples in RFC7946 due to the array brackets for the coordinates list being omitted. This deviation in expected json format prevents deserialization of the output back to the original Geometry. Preventing this feature from activating on the coordinates list in Geometry, even when enabled in the ObjectMapper, resolves the breaking of the idempotent nature of serialization and deserialization by keeping the output as close to the examples in RFC7946 as possible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a
Geometrycontaining a single list ofLngLatAltwithin its coordinates list was serialized using an ObjectMapper with SerializationFeature.WRITE_SINGLE_ELEM_ARRAYS_UNWRAPPED enabled the resulting output no longer matched the examples in RFC7946 due to the array brackets for the coordinates list being omitted. This deviation in expected json format prevents deserialization of the output back to the originalGeometry. Preventing this feature from activating on the coordinates list inGeometry, even when enabled in theObjectMapper, resolves the breaking of the idempotent nature of serialization and deserialization by keeping the output as close to the examples in RFC7946 as possible.Intended to resolve #68