Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keep history of opened files #126

Open
TomTasche opened this issue Aug 25, 2019 · 2 comments
Open

keep history of opened files #126

TomTasche opened this issue Aug 25, 2019 · 2 comments
Labels

Comments

@TomTasche
Copy link
Member

at the moment we only store URLs of documents a user attempted to open previously. we should conisder copying those documents to our internal cache and show a nice list of them at startup.

@TomTasche TomTasche added the UI label Aug 25, 2019
@ViliusSutkus89
Copy link
Contributor

Agree on the "show a nice list" part, but I suggest for us to not keep the source files. We already have converted and cached HTMLs, let's just use that.

End user would click on document.odt in the recent documents list and the app would instantly open cached document.odt.html. We could do the same for externally opened documents too, but then we we need to keep a hash of source file, to know if the source file is modified or not.

Not keeping copies of source files moves us closer to the possibility of converting straight from the source, instead of copying to cache and converting from cache. Converting straight from the source implies using android.net.Uri as input, instead of java.io.File . pdf2htmlEX-Android can't handle Uri's yet, but eventually ... opendocument-app/pdf2htmlEX-Android#27 . Copy prevented is time and cache space saved.

@TomTasche
Copy link
Member Author

I suggest for us to not keep the source files

We need the source file for editing. That only applies to ODF (ODT, ODS, ODP, ODG), but that's our main audience.

If it helps we could get rid of java.io.File though and use android.net.Uri instead. The cache already has a valid Uri too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants