Problem with gateLowerEdgeLevel of orifice

[rhutten]

Problem
The gateLowerEdgeLevel of an orifice is the position of the gate door's lower edge [m AD]. This is an absolute value in D-Flow FM.

However, the gateLowerEdgeLevels of orifices resulting from the D-HyDAMO converter is a relative value with respect to the crestLevel (laagstedoorstroomhoogte). This results from the 'hoogteopening' [m] being assigned as gateLowerEdgeLevel. More information about the D-HyDAMO onderspuier (orifice) can be found here.

The code below shows how the hoogteopening is assigned as gateLowerEdgeLevel:

1. generate_weirs function in delft3dfmpy/converters/hydamo_to_dflowfm.py:
2. weirs_from_hydamo function in delft3dfmpy/io/dfmreader.py:
   

Proposed solution

Adjust line 158 in generate_weirs function in delft3dfmpy/converters/hydamo_to_dflowfm.py to
orifices_dfm.at[idx, 'schuifhoogte'] = str(weir_opening.laagstedoorstroomhoogte + weir_mandev.hoogteopening)

[rhutten]

@RuudHurkmans, I checked the code in more detail. See above my proposed solution.

[RuudHurkmans]

This is correct, 'hoogteopening' was treated as an absolute level, but is in the HyDAMO format relative to the crest. In the code on github, the above solution has been implemented and it will be in the next release of the installable version.

As a workaround, in the meantime, an orifice can be added in the notebook as follows:

Here, an absolute value (m+NAP) should be provided, such as D-HYDRO expects it.